Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed missing 'recovery' path in oathkeeper access-rules.yml #763

Merged
merged 1 commit into from Oct 15, 2020

Conversation

c0depwn
Copy link
Contributor

@c0depwn c0depwn commented Oct 14, 2020

Related issue

closes #762

Proposed changes

Change contrib/oathkeeper/access-rules.yml on line 24

-
  id: "ory:kratos-selfservice-ui-node:anonymous"
  upstream:
    preserve_host: true
    url: "http://kratos-selfservice-ui-node:4435"
  match:
    url: "http://127.0.0.1:4455/<{error,verify,auth/*,**.css,**.js}{/,}>" # add 'recovery' here
...

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2020

CLA assistant check
All committers have signed the CLA.

@c0depwn c0depwn changed the title contrib: fixed missing 'recovery' path in oathkeeper access-rules.yml fix: fixed missing 'recovery' path in oathkeeper access-rules.yml Oct 14, 2020
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you 👍

@aeneasr aeneasr merged commit f180dba into ory:master Oct 15, 2020
@aeneasr
Copy link
Member

aeneasr commented Oct 15, 2020

Awesome 🎉

Thank you for your contribution!

@c0depwn
Copy link
Contributor Author

c0depwn commented Oct 15, 2020

Happy to help where I am able to 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contrib/quickstart/access-rules.yml is missing 'recovery'
4 participants