Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs wrong name #797

Merged
merged 3 commits into from
Oct 28, 2020
Merged

fix: docs wrong name #797

merged 3 commits into from
Oct 28, 2020

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Oct 28, 2020

The link to identity-data-model was still named identity-user-model thus broken.
I didnt change the name of the document cause I thought it might break something, but would be good to change it as well.
Let me know if I should go ahead and change it.

I tested all links now locally and it worked fine!
(btw first time i figured out how to build kratos docs locally :D, will include a how-to in the contribute to docs soon!)

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

.mdx was missing
The link to identity-data-model was still named identity-user-model thus broken.
@aeneasr aeneasr merged commit a4de293 into ory:master Oct 28, 2020
@vinckr vinckr deleted the vince-fix-docs branch October 28, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants