-
-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Argon2 calibration CLI #803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great already! I have some ideas for improvement! :)
Do you think we should ditch the |
# Conflicts: # go.mod # go.sum
I think also that a quiet flag makes more sense! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Almost done! We need a page in the docs (maybe in guide?) which explains: "Choosing Argon2 Parameters". You could probably re-use the blog post!
Note to self: Commit message:
|
Did you see the page I added in the troubleshooting/debug section? |
I actually missed that and that page is very important. I still think it would make sense to have a guide for this also as it probably makes sense to first understand how to choose those parameters before the server crashes :) |
1 similar comment
I actually missed that and that page is very important. I still think it would make sense to have a guide for this also as it probably makes sense to first understand how to choose those parameters before the server crashes :) |
docs/sidebar.json
Outdated
@@ -90,7 +97,7 @@ | |||
] | |||
} | |||
], | |||
"Debug & Help": ["debug/csrf"], | |||
"Debug & Help": ["debug/csrf", "debug/argon2"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn, always forget the sidebar 🤦
Related issue
closes #723
closes #572
closes #647
Proposed changes
This adds a CLI that conducts measurements to allow choosing the best argon2 parameters.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further comments