Fix logger for AuditLoggerInfo when none is provided. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 15, 2018 14:57
This commit fixes an issue with the AuditLoggerInfo structure where a user may fail to provide a logger at the time the struct is instantiated. The method logger() for the AuditLoggerInfo structure handles this case by instantiating a default logger that logs to Stderr if no logger instance is provided. The logger() method simply needs to be used, and this commit adds that functionality.
This commit fixes an issue with the AuditLoggerInfo structure where a user may fail to provide a logger at the time the struct is instantiated. The method logger() for the AuditLoggerInfo structure handles this case by instantiating a default logger that logs to Stderr if no logger instance is provided. The logger() method simply needs to be used, and this commit adds that functionality. Signed-off-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
|
Nice, thank you! |
|
You're welcome @arekkas! Thanks for Ladon, it's been great for my needs 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with the AuditLoggerInfo structure where
a user may fail to provide a logger at the time the struct is instantiated.
The method logger() for the AuditLoggerInfo structure handles this case by
instantiating a default logger that logs to Stderr if no logger instance
is provided. The logger() method simply needs to be used, and this commit
adds that functionality.