Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BooleanCondition to ConditionFactories #113

Closed
wants to merge 1 commit into from
Closed

Add BooleanCondition to ConditionFactories #113

wants to merge 1 commit into from

Conversation

jon-whit
Copy link
Contributor

@jon-whit jon-whit commented Mar 13, 2018 •
edited
Loading

This commit adds the new BooleanCondition introduced in PR #111 to the ConditionFactories. This addition was missing in the original PR.

@jon-whit
Add BooleanCondition to ConditionFactories
4c60a0f 
This commit adds the new BooleanCondition introduced in [PR ory#111](ory#111) to the ConditionFactories. This additions was missing in the original PR.
@aeneasr
Copy link
Member

aeneasr commented Mar 14, 2018

Thank you! Could you also add tests here (to check for de/serialization, it's a test that breaks if this PR wasn't added) and a new test in condition_boolean_test.go which you can basically copy & paste from here.

Thank you for your contributions!

@aeneasr
Copy link
Member

aeneasr commented Oct 8, 2018

Closing because this repository is being archived. The logic from this PR has been added to ORY Keto.

@aeneasr aeneasr closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jon-whit @aeneasr