Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manager: MemoryManager.GetAll return sorted data #127

Merged
merged 1 commit into from
Mar 29, 2019
Merged

manager: MemoryManager.GetAll return sorted data #127

merged 1 commit into from
Mar 29, 2019

Conversation

datastream
Copy link
Contributor

  • avoid GetAll(limit, offset int64) return random policies

Signed-off-by: datastream guxianjie@gmail.com

@aeneasr
Copy link
Member

aeneasr commented Jan 2, 2019

Can you please add a test for this? :)

@aeneasr
Copy link
Member

aeneasr commented Jan 13, 2019

Are you still up for adding a test?

avoid GetAll(limit, offset int64) return random policies
a775acf 
Signed-off-by: datastream <guxianjie@gmail.com>
@datastream
Copy link
Contributor Author

Should I add more test data ?

@aeneasr
Copy link
Member

aeneasr commented Mar 28, 2019

No, that looks good, thank you!

@aeneasr aeneasr merged commit 7f1c376 into ory:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@datastream @aeneasr