Interface with Contexts #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I noticed the build failed. When I remove
from the manager_test_helper.go file, the build is able to go through successfully. Do I need to remove that from my PR in order to get the build to pass? |
|
Hey, is there anything preventing to merge this PR? We would like to use the context-aware functions, but cannot use the PR branch due to the different module declared. |
|
Same question here. I would love to get the changes getting merged |
|
@aeneasr Is this PR something that can still be included? |
|
I've closed this PR in favor of a new one: #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces context parameters from an issue created here: #154