Fix consistency of CIDR JSON example #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I first thought the field name for CIDR conditions always was ``remoteIpAddress``. When reading the tests code, I realize the field name in context had to match the condition key. I wonder whether it's necessary to phrase it explicitly, now that I know it :) But at least this tiny fix will help a bit! Thanks for the awesome library!
|
Perfect, thanks. Yes I think that part is explained poorly in the readme, could help to say it explicitly somewhere! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first thought the field name for CIDR conditions always was
remoteIpAddress. When reading the tests code, I realize the field name in context had to match the condition key.I wonder whether it's necessary to phrase it explicitly, now that I know it :) But at least this tiny fix will help a bit!
Thanks for the awesome library!