rule: Ignore query parameters when matching url in rules. (#139)

Signed-off-by: Stanislav Zapolsky <stszap@gmail.com>
ory · Dec 3, 2018 · 07eb99b · 07eb99b
1 parent ab5240e
commit 07eb99b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/rule/rule.go b/rule/rule.go
@@ -22,6 +22,7 @@ package rule
 
 import (
 	"encoding/json"
+	"fmt"
 	"hash/crc32"
 	"net/url"
 	"regexp"
@@ -124,7 +125,7 @@ func (r *Rule) IsMatching(method string, u *url.URL) error {
 		return errors.WithStack(err)
 	}
 
-	if !c.MatchString(u.String()) {
+	if !c.MatchString(fmt.Sprintf("%s://%s%s", u.Scheme, u.Host, u.Path)) {
 		return errors.Errorf("rule %s does not match URL %s", r.ID, u)
 	}
 

diff --git a/rule/rule_test.go b/rule/rule_test.go
@@ -43,5 +43,6 @@ func TestRule(t *testing.T) {
 	}
 
 	assert.NoError(t, r.IsMatching("DELETE", mustParse(t, "https://localhost/users/1234")))
+	assert.NoError(t, r.IsMatching("DELETE", mustParse(t, "https://localhost/users/1234?key=value&key1=value1")))
 	assert.Error(t, r.IsMatching("DELETE", mustParse(t, "https://localhost/users/abcd")))
 }