Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gzipped responses in check session URLs #836

Open
aeneasr opened this issue Sep 27, 2021 · 3 comments
Open

Support gzipped responses in check session URLs #836

aeneasr opened this issue Sep 27, 2021 · 3 comments

Comments

@aeneasr
Copy link
Member

aeneasr commented Sep 27, 2021

Describe the bug

See #835

@aeneasr aeneasr added the bug Something is not working. label Sep 27, 2021
@dreverri
Copy link

dreverri commented Sep 28, 2021

If a request manually sets the Accept-Encoding header the transport will not automatically decode the response.

https://pkg.go.dev/net/http#Transport.DisableCompression

Currently, it looks like oathkeeper copies all the headers from the original request so if the original request has the Accept-Encoding header the body will not decompressed.

for k, v := range r.Header {

@aeneasr aeneasr closed this as completed Oct 3, 2021
@aeneasr aeneasr reopened this Oct 3, 2021
@aeneasr
Copy link
Member Author

aeneasr commented Oct 3, 2021

Ah, I see, that makes sense!

@till
Copy link

till commented Feb 9, 2022

@aeneasr PR coming soon. We somehow hit that.

till added a commit to hostwithquantum/ory-oathkeeper-fork that referenced this issue Feb 9, 2022
till added a commit to hostwithquantum/ory-oathkeeper-fork that referenced this issue Feb 10, 2022
till added a commit to hostwithquantum/ory-oathkeeper-fork that referenced this issue Jun 23, 2022
till added a commit to hostwithquantum/ory-oathkeeper-fork that referenced this issue Jun 23, 2022
@kmherrmann kmherrmann removed the bug Something is not working. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants