-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add retry and timeout support in authorizers #883
Conversation
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
==========================================
+ Coverage 62.22% 62.35% +0.13%
==========================================
Files 102 102
Lines 4839 4877 +38
==========================================
+ Hits 3011 3041 +30
- Misses 1554 1558 +4
- Partials 274 278 +4
Continue to review full report at Codecov.
|
9b27cdf
to
93e2cf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)
6f6fb97
to
d092d50
Compare
e94e6ae
to
c6c5b01
Compare
Thank you very much! |
Related issue(s)
As for authenticators, it is possible to define a retry and timeout policy on remote authorizers.
This need was expressed in the issue #515.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments