Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add retry and timeout support in authorizers #883

Merged
merged 5 commits into from
Jan 6, 2022

Conversation

Sbou
Copy link
Contributor

@Sbou Sbou commented Dec 16, 2021

Related issue(s)

As for authenticators, it is possible to define a retry and timeout policy on remote authorizers.
This need was expressed in the issue #515.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@Sbou Sbou requested a review from aeneasr as a code owner December 16, 2021 16:57
@CLAassistant
Copy link

CLAassistant commented Dec 16, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #883 (e94e6ae) into master (168086e) will increase coverage by 0.13%.
The diff coverage is 78.94%.

❗ Current head e94e6ae differs from pull request most recent head 23d5e6a. Consider uploading reports for the commit 23d5e6a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
+ Coverage   62.22%   62.35%   +0.13%     
==========================================
  Files         102      102              
  Lines        4839     4877      +38     
==========================================
+ Hits         3011     3041      +30     
- Misses       1554     1558       +4     
- Partials      274      278       +4     
Impacted Files Coverage Δ
pipeline/authz/remote.go 79.74% <78.94%> (-0.26%) ⬇️
pipeline/authz/remote_json.go 92.00% <78.94%> (-4.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168086e...23d5e6a. Read the comment docs.

@Sbou Sbou changed the title Feat: Add retry and timeout support in authorizers feat: Add retry and timeout support in authorizers Dec 16, 2021
@Sbou Sbou force-pushed the feat/add-retry-and-timeout-support branch from 9b27cdf to 93e2cf1 Compare December 16, 2021 17:20
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)

pipeline/authz/remote_json.go Outdated Show resolved Hide resolved
pipeline/authz/remote.go Outdated Show resolved Hide resolved
@Sbou Sbou force-pushed the feat/add-retry-and-timeout-support branch from 6f6fb97 to d092d50 Compare January 3, 2022 08:48
@Sbou Sbou force-pushed the feat/add-retry-and-timeout-support branch from e94e6ae to c6c5b01 Compare January 5, 2022 09:08
@aeneasr
Copy link
Member

aeneasr commented Jan 6, 2022

Thank you very much!

@aeneasr aeneasr merged commit ec926b0 into ory:master Jan 6, 2022
@Sbou Sbou deleted the feat/add-retry-and-timeout-support branch January 6, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants