* Add credentials issuers headers to /judge responses. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Fardello <jmfardello@gmail.com>
|
Thank you for the contribution! I definitely understand the approach but am thinking if there is a better way to approach this. I'll let you know once I have some ideas. By the way, we should also do this for the cookie credential issuer! |
3 tasks
|
I am wondering if it is possible to integrate this into Oathkeeper. The lack of this feature prevents me from using it with Ambassador API Gateway. |
|
Yeah, I'll work on this over the weekend! |
aeneasr
added a commit
that referenced
this pull request
Apr 6, 2019
|
Thanks! About to try it from master. Any chances of new Oathkeeper release any time soon? ;) |
|
@aeneasr tested - works like charm, thanks again! |
|
Yes, preparing releases this week. Hopefully we’ll get it done by OEW. Glad it works as expected!
… On 8. Apr 2019, at 21:19, Nikolai Grigoriev ***@***.***> wrote:
Thanks! About to try it from master. Any chances of new Oathkeeper release any time soon? ;)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: José Fardello jmfardello@gmail.com
This PR adds credentials issuers headers for /judge, while the handler_test passes, I did not include any test.. I can't figure out how to properly configure NewCredentialsIssuerHeaders() in order to test this.