Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Sync Scope Strategies in Oathkeeper&Hydra #497

Merged
merged 6 commits into from Aug 26, 2020
Merged

docs: Sync Scope Strategies in Oathkeeper&Hydra #497

merged 6 commits into from Aug 26, 2020

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Aug 11, 2020

Put this in the "Guides" Section in ORY Oathkeeper?
Is this extensive enough?

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

Put this in the "Guides" Section in ORY Oathkeeper?
Is this extensive enough?
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in the "Guides" Section in ORY Oathkeeper?

Yes! You can do that in this PR!

Is this extensive enough?

Absolutely :)

docs/docs/scope-strategies-hydra.mdx Outdated Show resolved Hide resolved
docs/docs/scope-strategies-hydra.mdx Show resolved Hide resolved
docs/docs/scope-strategies-hydra.mdx Outdated Show resolved Hide resolved
vinckr and others added 4 commits August 11, 2020 14:46
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
@vinckr
Copy link
Member Author

vinckr commented Aug 11, 2020

Added it to sidebar.json under Guides

@vinckr vinckr requested a review from aeneasr August 17, 2020 12:50
@aeneasr aeneasr merged commit e1b1751 into ory:master Aug 26, 2020
azhang pushed a commit to blep-ai/oathkeeper that referenced this pull request Aug 31, 2020
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants