fix: Misleading HTTP status code for oauth2_client_credentials authenticator #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NavindrenBaskaran
changed the title
NavindrenBaskaran
force-pushed
the
master
branch
from
8eec8fd
to
273b7d8
Compare
|
@aeneasr I've managed to return proper HTTP Error response based on the oauth2 clientcredentials response. I'm in the midst of writing test for this fix, will want to get some feedback pertaining the implementation. |
NavindrenBaskaran
force-pushed
the
master
branch
7 times, most recently
from
d15ea24
to
aab5168
Compare
aeneasr
requested changes
Aug 26, 2020
| return errors.Wrapf(helper.ErrUpstreamServiceNotFound, err.Error()) | ||
| } else if rErr.Response.StatusCode == http.StatusUnauthorized { | ||
| return errors.Wrapf(helper.ErrUnauthorized, err.Error()) | ||
| } |
There was a problem hiding this comment.
A default case is missing. If that case were to happen, this would let the request pass even if an error occurred. I recommend using switch with a defaults!
There was a problem hiding this comment.
Hey @aeneasr, yeap have made unauthorized as the default case.
NavindrenBaskaran
force-pushed
the
master
branch
2 times, most recently
from
eb5d765
to
b123da1
Compare
NavindrenBaskaran
force-pushed
the
master
branch
from
f058099
to
2b4c1ed
Compare
|
Hey @aeneasr can help review this please. Thanks. |
aeneasr
approved these changes
Aug 31, 2020
|
Sorry for the slow response, this looks good! Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #496
Proposed changes
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further comments