Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade openapi-generator-cli version to 6.6.0 for elixir #283

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

tobbbles
Copy link
Contributor

@tobbbles tobbbles commented Jul 10, 2023

Fixes #282.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

There are still some annoying bugs and inconsistencies in the Elixir implementation of openapi-generator. My fingers are crossed for version 7.0.0 and the following PR OpenAPITools/openapi-generator#15746, which will introduce some breaking changes to any users currently using the Elixir clients, but brings massive improvements and overhauls.

@tobbbles tobbbles force-pushed the master branch 2 times, most recently from 3c0f961 to a6fdba8 Compare July 10, 2023 13:57
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

By the way, there's no need really to update the files in clients as those are autogenerated anyways :)

@aeneasr aeneasr merged commit 60cf534 into ory:master Jul 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ory Client for Elixir has a typo which breaks the client
2 participants