New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fullscreen view to group overview page #1435
Merged
sysrich
merged 5 commits into
os-autoinst:master
from
krauselukas:feature/fullscreen_group_overview
Sep 4, 2017
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
66bd8f1
Create base for fullscreen mode on group overview site
krauselukas aafe4bf
Include just show latest comment feature
krauselukas 13d7172
Add disable comments feature in group overview
krauselukas e942d6e
Add fullscreen to group overview and rewind comments part
krauselukas 1a306a2
Fix uninitialized value error and typos
krauselukas File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
function hideNavbar(fullscreen) { | ||
|
||
var mouseY = 0; | ||
var navbarHeight = $(".navbar").outerHeight(); | ||
navbarHeight -= 30; | ||
|
||
if (($('#filter-fullscreen').is(':checked')) || (fullscreen == 1)) { | ||
$("#content").attr('id', 'content_fullscreen'); | ||
$(".navbar").addClass('hidden'); | ||
$(".footer").addClass('hidden'); | ||
$(".jumbotron").addClass('hidden'); | ||
if (fullscreen == 1) { | ||
$("#group_description").addClass('hidden'); | ||
} | ||
document.addEventListener('mousemove', function(e){ | ||
mouseY = e.clientY || e.pageY; | ||
if (mouseY < navbarHeight) { | ||
$(".navbar").removeClass('hidden').addClass('show'); | ||
} | ||
else if (mouseY > navbarHeight) { | ||
if (!$("li").hasClass('dropdown open')) { | ||
$(".navbar").removeClass('show').addClass('hidden'); | ||
} | ||
} | ||
}, false); | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,12 @@ | |
% my $selected = $rtagged{$only_tagged}; | ||
%= b join(' / ', map { $_ eq $selected ? "<b>$_</b>" : link_to($_ => url_with->query([only_tagged => $tagged{$_}])) } reverse sort keys %tagged); | ||
</div> | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @okurz after you pointed out the "limit to" section, i made the full screen mode part of it |
||
<div id="mode_section"> | ||
Set mode to | ||
% if ($fullscreen == 0) { | ||
<%= link_to url_for->query(fullscreen => 1)->to_abs => begin %>full screen<% end %> | ||
% } else { | ||
<%= link_to url_for->query(fullscreen => 0)->to_abs => begin %>default view<% end %> | ||
% } | ||
</div> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since i'm using this function related to fullscreen on more than one place, i thought it would be better to make a seperate file for it