-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fullscreen view to group overview page #1435
Add fullscreen view to group overview page #1435
Conversation
lib/OpenQA/WebAPI/Controller/Main.pm
Outdated
@@ -123,6 +126,8 @@ sub group_overview { | |||
$self->stash('only_tagged', $only_tagged); | |||
$self->stash('comments', \@comments); | |||
$self->stash('pinned_comments', \@pinned_comments); | |||
$self->stash('latest_comment', $latest_comment); | |||
$self->stash('show_comments', $show_comments); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is the only use of these variables I suggest to directly query the params method here, i.e.
$self->stash('latest_comment', $self->param('latest_comment'));
…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stash is not needed if the unique purpose is to use it in the template
<button type="submit" class="btn btn-default">Apply</button> | ||
</form> | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to focus on one thing at a time in this PR, e.g. either full screen or "show comments" but the general idea is very much appreciated. But keep in mind that we have now a "limit to …" line just below the build bars and this dynamic filter box further below the comments. Probably one of two approaches should be followed consistently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okurz Allright, totally overlooked it, thanks for the hint.
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
==========================================
+ Coverage 87.52% 87.52% +<.01%
==========================================
Files 105 105
Lines 7918 7919 +1
==========================================
+ Hits 6930 6931 +1
Misses 988 988
Continue to review full report at Codecov.
|
aa36f4a
to
300072e
Compare
300072e
to
e942d6e
Compare
@@ -0,0 +1,27 @@ | |||
function hideNavbar(fullscreen) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since i'm using this function related to fullscreen on more than one place, i thought it would be better to make a seperate file for it
@@ -7,3 +7,12 @@ | |||
% my $selected = $rtagged{$only_tagged}; | |||
%= b join(' / ', map { $_ eq $selected ? "<b>$_</b>" : link_to($_ => url_with->query([only_tagged => $tagged{$_}])) } reverse sort keys %tagged); | |||
</div> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okurz after you pointed out the "limit to" section, i made the full screen mode part of it
I rewinded the comments part, and will make a seperate PR for it |
5c63ea5
to
1a306a2
Compare
No description provided.