Return 0 by default on worker's try_lock_asset() #1478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of database locks, we attempt to rollback, but we are returning the $dbh->rollback() result, which leads to unexpected results. In this way we return 0 by default, and result otherwise. This is still far from a correct solution since it can still go into deep loop. Besides, toggle_asset_lock() can be potentially subject to the same issue. See related Progress issue: https://progress.opensuse.org/issues/26088
|
looks reasonable to me |
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
==========================================
- Coverage 88.21% 88.21% -0.01%
==========================================
Files 105 105
Lines 7959 7958 -1
==========================================
- Hits 7021 7020 -1
Misses 938 938
Continue to review full report at Codecov.
|
mudler
changed the title
|
merged in 1467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of database locks, we attempt to rollback, but we are returning
the
$dbh->rollback()result, which leads to unexpected results. In thisway we return 0 by default, and result otherwise. This is still far from
a correct solution since it can still go into deep loop.
Besides, toggle_asset_lock() can be potentially subject to the same
issue.
See related Progress issue: https://progress.opensuse.org/issues/26088