Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 0 by default on worker's try_lock_asset() #1478

Closed
wants to merge 1 commit into from
Closed

Return 0 by default on worker's try_lock_asset() #1478

wants to merge 1 commit into from

Commits on Oct 17, 2017

  1. Return 0 by default on worker's try_lock_asset() 

    In case of database locks, we attempt to rollback, but we are returning
the $dbh->rollback() result, which leads to unexpected results. In this
way we return 0 by default, and result otherwise. This is still far from
a correct solution since it can still go into deep loop.

Besides, toggle_asset_lock() can be potentially subject to the same
issue.

See related Progress issue: https://progress.opensuse.org/issues/26088
    @mudler
    mudler committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    286dec5 View commit details
    Browse the repository at this point in the history