-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocked_by revert #1747
Blocked_by revert #1747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests should be eventually fixed but so far looks like this is a go, when we're ready
So is this revert reverted again? |
@coolo how so? But indeed, this is what got reverted |
Please revert to the new scheduler for master |
@coolo I think it's better to reach a middle ground here. We got a very broken build during a beta week, and was not really fun. I can propose that we can create a new branch and pr for it and work there, as the current one is working and behaving... so that we don't rush. But also for this kind of things, we need some more tooling, like fake workers that work with a full build, that includes similar setup as what we have in OSD, which is what we missed last time. I'm not sure you'd like the idea though, but might be more helpful in the long run |
Sorry, no. You reverted the very same day I went on vacation and there was no 'very broken build' before my vacation. So if you had a very broken build then not because of this revert. So revert this revert |
The revert got merged on 17. Aug. So when I remember dates correctly, the new scheduler was on master the first week of your vacation. One more thing to mention is that the new scheduler broke the testsuite. That impaired developing other aspects of openQA. Note that there's still a big pile of outstanding PRs. |
what's on master doesn't matter too much - on 13th @mudler deployed this branch |
It was deployed on osd by the EOD on 13th, there was an early RC build on 11, that build was not looking good through the weekend, with a lot of jobs that were blocked when they shouldn't have, and jobs with incorrect dependencies et al. (On top of that, sum the ammount of maintenance requests...) |
I'm not saying there is nothing left to fix - I'm saying: revert the revert |
Just for reference, this is what is currently deployed on osd and o3