docker: Upgrade container packages before running tests #1748
Conversation
|
But i would rather drop the cpanm mechanisms to make it fail when trying to upgrade packages, it's rather annoying than useful |
…point while running tests
Codecov Report
@@ Coverage Diff @@
## master #1748 +/- ##
==========================================
- Coverage 80.91% 67.22% -13.7%
==========================================
Files 139 123 -16
Lines 9679 9021 -658
==========================================
- Hits 7832 6064 -1768
- Misses 1847 2957 +1110
Continue to review full report at Codecov.
|
mudler
force-pushed
the
docker_upgrade_packages
branch
6 times, most recently
from
99f8d58
to
3d853a5
Compare
mudler
force-pushed
the
docker_upgrade_packages
branch
from
f7fb502
to
45b603a
Compare
mudler
changed the title
- add UPGRADE_FROM_ZYPPER
mudler
force-pushed
the
docker_upgrade_packages
branch
from
a10be1b
to
c15d3e9
Compare
|
The errors in the CI are gone when #1747 is applied, but it's hanging on developer mode tests https://travis-ci.org/mudler/openQA/jobs/416778791 |
mudler
changed the title
| cpanm -n --mirror http://no.where/ --installdeps . | ||
| [ "$INSTALL_FROM_CPAN" -eq 1 ] && \ | ||
| (cpanm --local-lib=~/perl5 local::lib && cpanm -n --installdeps . ) || \ | ||
| cpanm -n --mirror http://no.where/ --installdeps . | ||
| if ! [ $? -eq 0 ]; then |
There was a problem hiding this comment.
in this case, if INSTALL_FROM_CPAN is not set, the exit of the cd that is previous is what's evaluated right?... I think we can remove then the check
There was a problem hiding this comment.
right, will address this in another PR
|
|
||
| echo ">> Running tests" | ||
|
|
||
| dbus-run-session -- sh -c "$*" |
We need something like this - or either rebuild the docker image more frequently (assuming that it's upgrading packages during docker build phase).
This is for a later discussion @foursixnine, just opening the PR just to give a rough idea of what we do already in os-autoinst (but there we rebuild the docker image each time, not here, thus tests will fail anyway).