Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: os-autoinst adjustments for failing developer fullstack test #1782

Closed

Conversation

Martchus
Copy link
Contributor

@Martchus Martchus commented Sep 11, 2018

This is not intended to be merged - I just want to run the CI. Hopefully my adjustments to make it pick my os-autoinst branch at os-autoinst/os-autoinst#1022 will work.

@codecov
Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #1782 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1782      +/-   ##
==========================================
+ Coverage    89.9%   89.99%   +0.08%     
==========================================
  Files         139      139              
  Lines        9791     9791              
==========================================
+ Hits         8803     8811       +8     
+ Misses        988      980       -8
Impacted Files Coverage Δ
lib/OpenQA/Schema/Result/Workers.pm 90.1% <0%> (-6.6%) ⬇️
lib/OpenQA/Worker/Commands.pm 85.71% <0%> (-2.6%) ⬇️
lib/OpenQA/WebSockets/Server.pm 89.95% <0%> (-2.29%) ⬇️
lib/OpenQA/Worker/Common.pm 78.1% <0%> (-2.19%) ⬇️
lib/OpenQA/Scheduler/Scheduler.pm 85.26% <0%> (-0.53%) ⬇️
lib/OpenQA/Utils.pm 92.64% <0%> (+0.21%) ⬆️
lib/OpenQA/Worker/Engines/isotovideo.pm 95.54% <0%> (+0.63%) ⬆️
lib/OpenQA/Worker/Jobs.pm 82.33% <0%> (+0.91%) ⬆️
lib/OpenQA/WebAPI/Controller/LiveViewHandler.pm 97.66% <0%> (+1.16%) ⬆️
lib/OpenQA/WebAPI/Controller/Developer.pm 100% <0%> (+3.33%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de30ae3...f70a11c. Read the comment docs.

@Martchus
Copy link
Contributor Author

Martchus commented Sep 11, 2018

All tests passed. For further testing, I'll re-trigger the developer fullstack test nevertheless.

Note that the changes unfortunately broke os-autoinst's testsuite which needs to be adapted. What cause os-autoinst's tests to fail was just some leftover from debugging.

The fullstack test passed 2 times in a row and the developer fullstack test 6 times. No failure so far at all :-)

@Martchus Martchus closed this Sep 12, 2018
@Martchus Martchus deleted the revert_to_new_scheduler branch September 12, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant