Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cgroup creation #2389

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Fix cgroup creation #2389

merged 1 commit into from
Oct 11, 2019

Conversation

Martchus
Copy link
Contributor

  • Pass name to groupv2 function to prevent Failed creating CGroup subtree 'Invalid path at /usr/lib/perl5/vendor_perl/5.26.1/Mojo/IOLoop/ReadWriteProcess/CGroup.pm line 35.
  • Improve coding style
  • Improve error messages
  • Separate temp dir creation from code dealing with cgroups
  • See https://progress.opensuse.org/issues/56993

* Pass name to groupv2 function to prevent 'Failed creating
  CGroup subtree 'Invalid path at /usr/lib/perl5/vendor_perl/
  5.26.1/Mojo/IOLoop/ReadWriteProcess/CGroup.pm line 35.'
* Improve coding style
* Improve error messages
* Separate temp dir creation from code dealing with cgroups
* See https://progress.opensuse.org/issues/56993
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #2389 into master will decrease coverage by 0.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2389      +/-   ##
=========================================
- Coverage   86.91%   86.9%   -0.02%     
=========================================
  Files         168     168              
  Lines       11160   11187      +27     
=========================================
+ Hits         9700    9722      +22     
- Misses       1460    1465       +5
Impacted Files Coverage Δ
lib/OpenQA/Worker/Engines/isotovideo.pm 93.83% <88.23%> (-0.75%) ⬇️
lib/OpenQA/WebSockets.pm 92.75% <0%> (-1.45%) ⬇️
lib/OpenQA/Schema/Result/Jobs.pm 86.13% <0%> (-0.82%) ⬇️
lib/OpenQA/WebAPI/Controller/API/V1/JobTemplate.pm 94.18% <0%> (+0.06%) ⬆️
lib/OpenQA/WebAPI/Controller/API/V1/Table.pm 97.56% <0%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ff0eb...acf1954. Read the comment docs.

@Martchus Martchus merged commit caa3f87 into os-autoinst:master Oct 11, 2019
@Martchus Martchus deleted the cgroups branch October 11, 2019 16:41
coolo pushed a commit that referenced this pull request Oct 11, 2019
commit caa3f87
Merge: bb052e8 acf1954
Author:     Martchus <martchus@gmx.net>
AuthorDate: Fri Oct 11 18:41:14 2019 +0200
Commit:     GitHub <noreply@github.com>
CommitDate: Fri Oct 11 18:41:14 2019 +0200

    Merge pull request #2389 from Martchus/cgroups

    Fix cgroup creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants