Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use croak in OpenQA::Utils::log_fatal #2436

Closed
wants to merge 1 commit into from

Conversation

perlpunk
Copy link
Contributor

...instead of die.
This way we will get the correct location of the calling method

Issue: https://progress.opensuse.org/issues/57776

...instead of die.
This way we will get the correct location of the calling method

Issue: https://progress.opensuse.org/issues/57776
@perlpunk
Copy link
Contributor Author

Fixed perltidy error and force-pushed

Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@perlpunk perlpunk closed this Oct 25, 2019
@perlpunk perlpunk deleted the log-fatal branch October 25, 2019 14:21
@perlpunk
Copy link
Contributor Author

Accidentally removed my branch :-/

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #2436 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2436   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files         168      168           
  Lines       11078    11078           
=======================================
  Hits         9653     9653           
  Misses       1425     1425
Impacted Files Coverage Δ
lib/OpenQA/Utils.pm 92.94% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3a5ec...435dd2b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants