Use croak in OpenQA::Utils::log_fatal
#2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...instead of die. This way we will get the correct location of the calling method Issue: https://progress.opensuse.org/issues/57776
Martchus
approved these changes
Oct 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #2438 +/- ##
=======================================
Coverage 87.13% 87.13%
=======================================
Files 168 168
Lines 11078 11078
=======================================
Hits 9653 9653
Misses 1425 1425
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of die.
This way we will get the correct location of the calling method
Issue: https://progress.opensuse.org/issues/57776
I accidentally deleted my branch in #2436, so this is the same change