Improve video player #2605
Merged
Improve video player #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
reviewed
Dec 16, 2019
| @@ -4,7 +4,7 @@ | |||
| % for my $resultfile (@$resultfiles) { | |||
| <li> | |||
| % if($resultfile =~ /video.ogv$/) { | |||
| %= link_to url_for('test_file', testid => $testid, filename => 'video.ogv') => begin | |||
| %= link_to url_for('video', testid => $testid) => begin | |||
There was a problem hiding this comment.
That makes it harder to download the video or to copy the link to open it with mpv for example. I would preserve the old link and add the player only additionally.
There was a problem hiding this comment.
yes, good idea. After all the "logs & assets" tab should provide the files for download first-hand
Based on an idea by Stefan Bruens we can use timestamp information relating the video runtime to realtime in a video player. Related progress issue: https://progress.opensuse.org/issues/42050
okurz
force-pushed
the
feature/video2_less_controls
branch
from
dc056ee
to
fb71858
Compare
Martchus
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on an idea by Stefan Bruens we can use timestamp information
relating the video runtime to realtime in a video player.
Related progress issue: https://progress.opensuse.org/issues/42050