Move worker reported back from scheduler to webui #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
approved these changes
Dec 16, 2019
| @@ -355,7 +370,6 @@ is_deeply($grabbed->{settings}, $job_ref->{settings}, "settings correct"); | |||
| my $job3_id = $job->id; | |||
| my $job_id = $grabbed->{id}; | |||
|
|
|||
| sleep 1; | |||
There was a problem hiding this comment.
you are deleting sleeps in code. I love you for this already! 😗 😏
|
only tidy check failed. |
* Move the code from the scheduler and web socket server to the web UI instead of having it spread over different places * Improve scalability because the web UI can make use of preforking * Avoid redundant code * Improve error handling of reschedule_state/reschedule_rollback * Remove code for marking the current job of the worker as running when it connects to the web socket server because on the first status update it will be considered running anyways * Do not incomplete assigned jobs on worker re-registration but re-schedule them instead like it was done on the web socket server side already * Do the re-scheduling of assigned jobs directly within the web socket server. (It can not moved to the web UI for reasons stated in code comments.) * See https://progress.opensuse.org/issues/60866
* Reduce the execution time by several seconds by reducing/mocking the status update interval and some sleeps * Add further notes * Make the unstable workers not that unstable for the sake of this tests. There's still 'simulation of heavy unstable load'.
Martchus
force-pushed
the
move_worker_reported_back_from_scheduler_to_webui
branch
from
ca5a73b
to
b664fff
Compare
Martchus
deleted the
move_worker_reported_back_from_scheduler_to_webui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2595 which was buggy.
Marking previous jobs of a worker as incomplete when it shows up again is so far handled within the web socket server and the registration API route. This change moves all aspects of handling this to the API. This will hopefully scale better because the regular API can use preforking.
See https://progress.opensuse.org/issues/60866