Move job incompletion code on worker connect to one place #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
force-pushed
the
move_worker_reported_back_from_scheduler_to_webui
branch
from
0d8041a
to
3a25a2e
Compare
* Move the code entirely from the web socket server to the web UI instead of having it spread over different places * Improve scalability because the web UI can make use of preforking * Avoid redundant code * Improve error handling of reschedule_state/reschedule_rollback * Remove code for marking the current job of the worker as running when it connects to the web socket server because on the first status update it will be considered running anyways * Do not incomplete assigned jobs on worker re-registration but re-schedule them instead like it was done on the web socket server side already * See https://progress.opensuse.org/issues/60866
Martchus
force-pushed
the
move_worker_reported_back_from_scheduler_to_webui
branch
from
3a25a2e
to
f634359
Compare
okurz
reviewed
Dec 13, 2019
|
I've pushed further commits to the branch (https://github.com/Martchus/openQA/tree/move_worker_reported_back_from_scheduler_to_webui) but GitHub doesn't show them in the PR. Maybe it is just a delay; otherwise I'll open a new PR. (I also can not close the PR right now.) |
|
strange. Let me close the PR and you can try to either reopen it or open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking previous jobs of a worker as incomplete when it shows up again is so far handled within the web socket server and the registration API route. This change moves all aspects of handling this to the API. This will hopefully scale better because the regular API can use preforking.
See https://progress.opensuse.org/issues/60866