Fix support for symlinked cache dirs #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
approved these changes
Jan 13, 2020
|
Can you please put more details into the git commit message, not only the PR description. |
kraih
force-pushed
the
cache_service_symlinks
branch
from
1111cef
to
fda0a00
Compare
|
@okurz Done. |
okurz
approved these changes
Jan 13, 2020
|
I'll actually test the patch on the staging machines first, just to be sure i didn't forget anything else in the new tests. |
kraih
added
the
acceptance-tests-needed
Codecov Report
@@ Coverage Diff @@
## master #2658 +/- ##
=========================================
- Coverage 91.86% 91.8% -0.07%
=========================================
Files 183 183
Lines 11475 11476 +1
=========================================
- Hits 10542 10536 -6
- Misses 933 940 +7
Continue to review full report at Codecov.
|
|
Never change @codecov. 🙄 |
kraih
removed
the
acceptance-tests-needed
|
Everything looks good on the staging machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #2652 on the staging machines last week, i noticed that symlinked cache directories on workers did not actually work yet. This should resolve the problem.
Progress: https://progress.opensuse.org/issues/55373