Job templates: Escape dot in regex #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
approved these changes
May 19, 2020
|
Will fix a typo in a test label, but github doesn't let me push right now... |
perlpunk
force-pushed
the
invalid-hidden-key
branch
2 times, most recently
from
3643aaa
to
11ca651
Compare
Issue: https://progress.opensuse.org/issues/66781 Also add a test to detect invalid top level keys
perlpunk
force-pushed
the
invalid-hidden-key
branch
from
11ca651
to
978b3f8
Compare
Martchus
approved these changes
May 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #3104 +/- ##
=======================================
Coverage 92.02% 92.03%
=======================================
Files 211 211
Lines 12851 12864 +13
=======================================
+ Hits 11826 11839 +13
Misses 1025 1025
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://progress.opensuse.org/issues/66781
Also add a test to detect invalid top level keys