Job templates: Escape dot in regex

public/schema/JobTemplates-01.yaml

@@ -7,7 +7,7 @@ required:
 - products
 - scenarios
 patternProperties:
-  "^.[a-z0-9_]+$":
+  '^\.[a-z0-9_]+$':
     type: object
     description: Definitions that can be re-used
 
@@ -17,11 +17,11 @@ properties:
     type: object
     additionalProperties: false
     patternProperties:
-      "^[a-z0-9_]+$":
+      '^[a-z0-9_]+$':
         type: object
         description: The architecture of the test suite(s) eg. ppc64le
         patternProperties:
-          "^.*$":
+          '^.*$':
             type: array
             description: The product to run the test suite(s) on
             items:
@@ -33,7 +33,7 @@ properties:
                 description: A test suite with machine and/ or priority specified, or a custom job template name if testsuite was specified
                 additionalProperties: false
                 patternProperties:
-                  &testsuite-pattern "^[A-Za-z\\s0-9_*.+-]+$":
+                  &testsuite-pattern '^[A-Za-z\s0-9_*.+-]+$':
                     type: object
                     additionalProperties: false
                     properties:
@@ -50,7 +50,7 @@ properties:
                         description: Additional test variables to be set
                         additionalProperties: false
                         patternProperties:
-                          "^[A-Z_+]+[A-Z0-9_]*$":
+                          '^[A-Z_+]+[A-Z0-9_]*$':
                             type: string
                       testsuite:
                         type: [string, 'null']
@@ -65,7 +65,7 @@ properties:
     type: object
     additionalProperties: false
     patternProperties:
-      "^[a-z0-9_]+$":
+      '^[a-z0-9_]+$':
         type: object
         description: The architecture to define a default configuration for eg. ppc64le
         required:
@@ -81,7 +81,7 @@ properties:
     type: object
     additionalProperties: false
     patternProperties:
-      "^[A-Za-z0-9._*-]+$":
+      '^[A-Za-z0-9._*-]+$':
         type: object
         description: The name of a product (medium)
         required:

t/16-utils-job-templates.t

@@ -22,10 +22,11 @@ use lib "$Bin/lib";
 use OpenQA::YAML qw(load_yaml validate_data);
 use Mojo::File qw(path tempdir tempfile);
 
-my $schema               = "$Bin/../public/schema/JobTemplates-01.yaml";
-my $template_openqa      = "$Bin/data/job-templates/openqa.yaml";
-my $template_openqa_null = "$Bin/data/job-templates/openqa-null.yaml";
-my %default_args         = (schema_file => $schema);
+my $schema                  = "$Bin/../public/schema/JobTemplates-01.yaml";
+my $template_openqa         = "$Bin/data/job-templates/openqa.yaml";
+my $template_openqa_null    = "$Bin/data/job-templates/openqa-null.yaml";
+my $template_openqa_invalid = "$Bin/data/job-templates/openqa-invalid.yaml";
+my %default_args            = (schema_file => $schema);
 
 my $invalid_schema = "$Bin/data/job-templates/schema-invalid.yaml";
 
@@ -50,4 +51,11 @@ if (@$errors) {
 }
 is scalar @$errors, 0, "Valid template with testsuite null - no errors";
 
+$errors = validate_data(%default_args, data => load_yaml(file => $template_openqa_invalid));
+is scalar @$errors, 1, "Invalid toplevel key detected"
+  or do {
+    diag "Error: $_" for @$errors;
+  };
+like($errors->[0], qr{/: Properties not allowed: invalid.}, 'Invalid toplevel key error message');
+
 done_testing;

t/data/job-templates/openqa-invalid.yaml

@@ -0,0 +1,15 @@
+invalid:
+  toplevel: key
+
+products:
+  foo:
+    distri: openqa
+    flavor: dev
+    version: '*'
+scenarios:
+  x86_64:
+    foo:
+    - bar:
+        testsuite: null
+        settings:
+          FOO: BAR