Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NOVIDEO for jobs with increased MAX_JOB_TIME by default #3112

Merged
merged 2 commits into from
May 25, 2020

Conversation

Martchus
Copy link
Contributor

@Martchus Martchus commented May 22, 2020

The video contributes significantly to the log size. This is especially the
case for long-running results so it makes sense to disable the video there
by default.

See

The video contributes significantly to the log size. This is especially the
case for long-running results so it makes sense to disable the video there
by default.

See
* https://progress.opensuse.org/issues/66922
* https://progress.opensuse.org/issues/67087#note-3
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #3112 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3112      +/-   ##
==========================================
+ Coverage   92.02%   92.03%   +0.01%     
==========================================
  Files         211      211              
  Lines       12875    12883       +8     
==========================================
+ Hits        11848    11857       +9     
+ Misses       1027     1026       -1     
Impacted Files Coverage Δ
lib/OpenQA/Constants.pm 100.00% <100.00%> (ø)
lib/OpenQA/Worker/Job.pm 75.85% <100.00%> (+0.26%) ⬆️
lib/OpenQA/WebAPI/Plugin/Helpers.pm 95.91% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4741a71...ab74357. Read the comment docs.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good. And thanks for the quick result. The caveat is that it is not actually obvious that NOVIDEO is set automatically by openQA but also MAX_JOB_TIME isn't that obvious to know about. So if one finds "MAX_JOB_TIME" and sets a different value we can assume that user might also learn about NOVIDEO quickly :) I am thinking of a doc change to apply. That I can do myself as followup.

@Martchus
Copy link
Contributor Author

I can extend the documentation myself in a further PR. I couldn't find any place where MAX_JOB_TIME is introduced in the documentation so I'll check where it fits best.

@Martchus Martchus merged commit 5527d90 into os-autoinst:master May 25, 2020
@Martchus Martchus deleted the max-job-time branch May 25, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants