Change auto-refresh selector #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
reviewed
Sep 7, 2020
okurz
requested changes
Sep 8, 2020
ilausuch
force-pushed
the
auto_refresh_convert_value_field
branch
from
62bcf4e
to
133b4aa
Compare
okurz
approved these changes
Sep 10, 2020
Martchus
reviewed
Sep 10, 2020
ilausuch
force-pushed
the
auto_refresh_convert_value_field
branch
2 times, most recently
from
46f0a76
to
777074e
Compare
|
I added a fix for the test t.ui.14-dashboard-parents_t because of the new query parameter interval |
okurz
reviewed
Sep 14, 2020
Martchus
requested changes
Sep 14, 2020
ilausuch
force-pushed
the
auto_refresh_convert_value_field
branch
from
777074e
to
40a93a8
Compare
|
Done, thanks for the reviews |
|
I think it is more efficient if you call at least a subset of tests locally |
Actually the selector for the automatic refresh is several radio buttons with hardcoded values. In order to offer flexibility now is a numeric field
ilausuch
force-pushed
the
auto_refresh_convert_value_field
branch
from
40a93a8
to
a770849
Compare
Martchus
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://progress.opensuse.org/issues/17886
Actually the selector for the automatic refresh is several radio
buttons with hardcoded values.
In order to offer flexibility now is a numeric field
A enhancement of #3141