Add autorefresh in the index page for fullscreen mode feature #3141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3141 +/- ##
=======================================
Coverage 91.89% 91.90%
=======================================
Files 211 211
Lines 12921 12924 +3
=======================================
+ Hits 11874 11878 +4
+ Misses 1047 1046 -1
Continue to review full report at Codecov.
|
|
Could you start the PR title and commit messages with a verb in imperative so it is clear whether this is a fix/extension/improvement of an existing feature or a new feature? |
ilausuch
force-pushed
the
index_auto_refresh_full_screen
branch
from
dc21202
to
b56464c
Compare
|
Also is fixed a bug in the code that didn't show the interval selector when refresh the page and the full screen mode was on |
ilausuch
changed the title
ilausuch
force-pushed
the
index_auto_refresh_full_screen
branch
from
b56464c
to
871485b
Compare
ilausuch
force-pushed
the
index_auto_refresh_full_screen
branch
from
871485b
to
4f65c51
Compare
There was a problem hiding this comment.
I've tested it locally and the page now behaves rather weird. By default, the "Auto refresh" filter options are available and the fullscreen mode is disabled. I'd say that makes sense so far. The auto-reload might be used without the fullscreen mode. However, when toggling the fullscreen mode the "Auto refresh" filter options are toggled as well which doesn't make too much sense to me. It also seems like the auto refresh only works when the fullscreen mode is enabled.
The commit message is full of typos and grammar mistakes. Besides, it seems like it convers only to the CSS change.
|
Ok, I am removing the part that only allows auto-refresh in fullscreen mode |
|
your tests fail now in the cache step as the versions of packages can not be found anymore, see https://app.circleci.com/pipelines/github/os-autoinst/openQA/3181/workflows/7eeb8bf3-ee48-433d-a525-943e06cc17a6/jobs/30369/steps @kalikiana this makes me think that what is tested is actually not the to-be-merged state but pre-merge. @ilausuch please try to fix that by rebasing on a current master with updated dependencies.txt |
ilausuch
force-pushed
the
index_auto_refresh_full_screen
branch
from
4f65c51
to
c7f56cf
Compare
https://progress.opensuse.org/issues/17886 This new feature allows to autorefresh the index page with 30, 60, 120 and 180 seconds. The user controls the interval with the filter control panel.
The autorefresh filter is only visible and applicable when fullscreen is selected
Problem: When this page is in fullmode and the filter window is closed (for instance if we comeback keeping the fullscreen=1 query value in url) is impossible to open the filter panel because the header appears when the cursor enters in the filter panel area to be clicked Solution: Add additional margin to the top of the filter panel
ilausuch
force-pushed
the
index_auto_refresh_full_screen
branch
from
c7f56cf
to
7bf5866
Compare
|
Now is not necessary to be in a fullscreen mode to have auto-refresh. Also I rebased. |
|
t/ui/16-tests_job_next_previous.t failed. I doubt your changes should influence that though. Please squash the commits and we will see new test results anyway |
|
I've re-triggered only the failing UI tests. That should be faster. There's no need to squash commits locally anymore. |
https://progress.opensuse.org/issues/17886
This new feature allows to autorefresh the index page with 30, 60,
120 and 180 seconds. The user controls the interval with the
filter control panel.