Make the timeout to consider workers offline configurable #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Sep 14, 2020
Martchus
force-pushed
the
stale-job-detection
branch
from
7430378
to
7d35dd2
Compare
kalikiana
reviewed
Sep 15, 2020
okurz
approved these changes
Sep 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #3389 +/- ##
==========================================
+ Coverage 91.68% 91.71% +0.02%
==========================================
Files 216 216
Lines 13253 13264 +11
==========================================
+ Hits 12151 12165 +14
+ Misses 1102 1099 -3
Continue to review full report at Codecov.
|
* This should avoid jobs being stuck in the assigned state too long when a worker disconnects unexpectedly. * See https://progress.opensuse.org/issues/69784#note-11
* Avoid marking assigned jobs as incomplete and set them instead back to scheduled * Consider all jobs assigned to a worker (with directly chained dependencies multiple jobs might be assigned to a worker) * See https://progress.opensuse.org/issues/69784#note-11
Martchus
force-pushed
the
stale-job-detection
branch
from
7d35dd2
to
585a0a3
Compare
so similar to what @kalikiana was working on here we should also ensure that we have a time limit within 33-developer-mode.t which is less than 10m. I prepared #3393 for this. |
And, too, addressing the potential cause for it: #3394 |
kalikiana
approved these changes
Sep 16, 2020
|
@kalikiana excellent :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://progress.opensuse.org/issues/69784#note-12