Add systemd service for automatic system upgrades and reboots

[okurz]

This is based on what we already use on o3 (openqa.opensuse.org) to
automatically apply nightly system patching, package upgrades and
planning system reboots where required, e.g. after kernel upgrades.

Related progress issue: https://progress.opensuse.org/issues/70978

[ilausuch]

This is over my knowledge but seems good job

[Martchus]

I think it is ok to add yet another sub-package but generally I'm wondering whether we should stop adding everything to one spec file.

Unlike the other service file this service file is also very distribution-specific. It is questionable whether we should install the script and service file via the regular install target.

[okurz]

I think it is ok to add yet another sub-package but generally I'm wondering whether we should stop adding everything to one spec file.

Unlike the other service file this service file is also very distribution-specific. It is questionable whether we should install the script and service file via the regular install target.

Both points are linked. We use a single spec file because we first install everything in one call and then separate the files into packages.

I was considering the "distribution specific" aspect as well but I would only worry about that after we learned where we can do that better. It won't do any harm if the files are just present.

[Martchus]

It won't do any harm if the files are just present.

It means that other distributions won't use our install target at all or they need to remove files manually. Both seems annoying considering they'll have to keep their custom solution in sync with our install target.

I would only worry about that after we learned where we can do that better.

Just add another install target, e.g. install-opensuse for distribution-specific files.

[okurz]

Just add another install target, e.g. install-opensuse for distribution-specific files.

@mkittler DONE, please check.

[Martchus]

I've already unresolved one unaddressed review comment.

[codecov]

Codecov Report

Merging #3524 (1c9fcd5) into master (59caf76) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3524      +/-   ##
==========================================
- Coverage   95.61%   95.58%   -0.03%     
==========================================
  Files         366      366              
  Lines       31789    31789              
==========================================
- Hits        30394    30387       -7     
- Misses       1395     1402       +7     

Impacted Files	Coverage Δ
t/44-scripts.t	100.00% <100.00%> (ø)
t/lib/OpenQA/Test/Utils.pm	65.52% <0.00%> (-3.71%)	⬇️
t/05-scheduler-full.t	97.43% <0.00%> (-0.52%)	⬇️
t/lib/OpenQA/Test/FullstackUtils.pm	93.93% <0.00%> (+7.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59caf76...1c9fcd5. Read the comment docs.

[okurz]

Needed to add

BuildRequires: openSUSE-release

to openQA.spec so that /etc/os-release is present so that we can detect that we need to call the install-opensuse Makefile target

[okurz]

oh come on, finally all tests passed and now
"Rule: automatic merge (merge) — Base branch update has failed" :(