DO NOT MERGE: Test stability of t/ui/ui/25-developer_mode.t #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 91.0.4472.77 of `chromedriver` changed its behavior so `Selenium::Remote::WebElement` behaves different as well. This change adapts our tests to the following changes (in a backwards compatible way): * `Selenium::Remote::WebElement::get_attribute()` now returns `undef` instead of an empty string if the attribute is not present at all. * `Selenium::Remote::WebElement::get_value()` and `is_selected()` sometimes no longer return a value. Likely it depends on how these form properties are populated. Possible an unwanted side-effect of the `get_attribute()` change. See https://progress.opensuse.org/issues/93453#note-11
This reverts commit 3babb6f as tests have been adapted.
…ures The mocking of status updates was insufficient. It is not enough to override `updateStatus()` after loading the page because it might have already been invoked and therefore the initial status update is not actually prevented. This change allows to disable status updates from the beginning via a query parameter (which is only evaluated in test mode).
|
Looks like it is stable now but I'm giving it another run to be sure. |
|
It passed again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.