Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: Test stability of t/ui/ui/25-developer_mode.t #3942

Closed
wants to merge 4 commits into from
Closed

DO NOT MERGE: Test stability of t/ui/ui/25-developer_mode.t #3942

wants to merge 4 commits into from

Commits on Jun 10, 2021

  1. Adapt UI tests to chromedriver changes 

    Version 91.0.4472.77 of `chromedriver` changed its behavior so
`Selenium::Remote::WebElement` behaves different as well. This change
adapts our tests to the following changes (in a backwards compatible way):

* `Selenium::Remote::WebElement::get_attribute()` now returns `undef`
  instead of an empty string if the attribute is not present at all.
* `Selenium::Remote::WebElement::get_value()` and `is_selected()` sometimes
  no longer return a value. Likely it depends on how these form properties
  are populated. Possible an unwanted side-effect of the `get_attribute()`
  change.

See https://progress.opensuse.org/issues/93453#note-11
    @Martchus
    Martchus committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    2e938e2 View commit details
    Browse the repository at this point in the history

  2. Revert "Downgrade chromedriver from problematic version" 

    This reverts commit 3babb6f
as tests have been adapted.
    @Martchus
    Martchus committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    9ba942a View commit details
    Browse the repository at this point in the history

  3. Fix problem in t/ui/25-developer_mode.t leading to sporadic test fail… 

    …ures

The mocking of status updates was insufficient. It is not enough to
override `updateStatus()` after loading the page because it might have
already been invoked and therefore the initial status update is not
actually prevented. This change allows to disable status updates from the
beginning via a query parameter (which is only evaluated in test mode).
    @Martchus
    Martchus committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    9f9b10a View commit details
    Browse the repository at this point in the history

  4. DO NOT MERGE: Test stability of t/ui/ui/25-developer_mode.t

    @Martchus
    Martchus committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    1208167 View commit details
    Browse the repository at this point in the history