Optimize search: prefetch job columns #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
approved these changes
Jun 18, 2021
okurz
reviewed
Jun 19, 2021
Currently for every job-module result a `SELECT FROM job` is executed, when calling $job_module->job->name. The prefetch will save the job data in the object and so the extra SELECT is avoided. Additionally this commit reduces the selected columns to what is actually needed. A search for 'vlc' was reduced from 39s to 7s locally.
perlpunk
force-pushed
the
optimize-search
branch
from
3e2ffd5
to
64d6e00
Compare
Codecov Report
@@ Coverage Diff @@
## master #3969 +/- ##
==========================================
- Coverage 96.87% 96.86% -0.01%
==========================================
Files 370 370
Lines 32966 32966
==========================================
- Hits 31937 31934 -3
- Misses 1029 1032 +3
Continue to review full report at Codecov.
|
okurz
approved these changes
Jun 21, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for every job-module result a
SELECT FROM jobis executed,when calling
$job_module->job->name.The prefetch will save the job data in the object and so the extra
SELECT is avoided.
Additionally this commit reduces the selected columns to what is actually
needed.
A search for 'vlc'
/api/v1/experimental/search?q=vlcwas reduced from 39s to 7s locally.