Return errors on artefact creation correctly #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
force-pushed
the
artefact-error-handling
branch
from
ae31632
to
4ddf9fb
Compare
kalikiana
reviewed
Sep 7, 2021
* Return a 400/500 error when creating an artefact fails so the worker would log the error and retry in case of a 500 error * We've seen cases in production where result files are missing but no final upload error (after exhausing all attempts) is logged, see https://progress.opensuse.org/issues/94531#note-35. This change might fix those problems.
Martchus
force-pushed
the
artefact-error-handling
branch
from
4ddf9fb
to
c8d7443
Compare
Codecov Report
@@ Coverage Diff @@
## master #4179 +/- ##
==========================================
- Coverage 97.90% 97.90% -0.01%
==========================================
Files 369 369
Lines 33310 33308 -2
==========================================
- Hits 32612 32610 -2
Misses 698 698
Continue to review full report at Codecov.
|
kalikiana
approved these changes
Sep 8, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would log the error and retry in case of the 500 error
final upload error (after exhausing all attempts) is logged, see
https://progress.opensuse.org/issues/94531#note-35. This change might
fix those problems.