Simplify code for artefact creation #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove code for initializing otherwise unused variable `$days` * Remove code checking for return codes because the involved functions actually throw exceptions; this code paths were not covered by tests anyways and would have already lead to a 500 response * Write code in a more compact way
Codecov Report
@@ Coverage Diff @@
## master #4184 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 369 369
Lines 33308 33301 -7
=======================================
- Hits 32610 32604 -6
+ Misses 698 697 -1
Continue to review full report at Codecov.
|
kalikiana
approved these changes
Sep 9, 2021
perlpunk
approved these changes
Sep 10, 2021
openqabot
pushed a commit
to openqabot/openQA
that referenced
this pull request
Sep 11, 2021
commit 16e44e0 Merge: 2e8f6a0 3a9ea36 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Fri Sep 10 15:35:56 2021 +0000 Commit: GitHub <noreply@github.com> CommitDate: Fri Sep 10 15:35:56 2021 +0000 Merge pull request os-autoinst#4184 from Martchus/artefact-error-handling Simplify code for artefact creation
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$daysactually throw exceptions; this code paths were not covered by tests
anyways and would have already lead to a 500 response