Fix SQL error in refresh_assets caused by 5b14fe
#4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the asset cleanup fails due to an SQL error: ``` DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute failed: ERROR: invalid input syntax for type boolean: "" [for Statement "UPDATE assets SET fixed = ?, t_updated = ? WHERE id = ?" with ParamValues: 1='', 2='2021-09-28 15:01:21', 3='27487345'] at /usr/share/openqa/script/../lib/OpenQA/Schema/ResultSet/Assets.pm line 99 ``` Apparently DBIx cannot cope with the boolean here so one has to convert to int manually. See https://progress.opensuse.org/issues/97979#note-26
perlpunk
reviewed
Sep 28, 2021
| @@ -95,7 +95,7 @@ sub refresh_assets { | |||
| my ($self) = @_; | |||
|
|
|||
| while (my $asset = $self->next) { | |||
| my $is_fixed = $asset->is_fixed; | |||
| my $is_fixed = $asset->is_fixed ? 1 : 0; | |||
There was a problem hiding this comment.
Maybe this should be changed in the sub is_fixed directly?
There was a problem hiding this comment.
It should only be required here but I can also change is_fixed itself.
Codecov Report
@@ Coverage Diff @@
## master #4250 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 369 369
Lines 33421 33426 +5
=======================================
+ Hits 32726 32732 +6
+ Misses 695 694 -1
Continue to review full report at Codecov.
|
perlpunk
approved these changes
Sep 28, 2021
Amrysliu
approved these changes
Sep 29, 2021
okurz
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the asset cleanup fails due to an SQL error:
Apparently DBIx cannot cope with the boolean here so one
has to convert to int manually.
See https://progress.opensuse.org/issues/97979#note-26