Render the test_log value correctly when config has http url #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `gitrepodir` returns the url directly as it appears in the config file, when the `renderInvestigationTab` expects the value of `data-testgiturl` retrieved from `investigation_ajax` in the form of _http://github.com/<user>/<repo>/commit_ Apply the same substitution as in git before return Signed-off-by: ybonatakis <ybonatakis@suse.com>
Codecov Report
@@ Coverage Diff @@
## master #4366 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 371 371
Lines 33714 33719 +5
=======================================
+ Hits 33021 33026 +5
Misses 693 693
Continue to review full report at Codecov.
|
okurz
approved these changes
Nov 18, 2021
Martchus
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gitrepodirreturns the url directly as it appears in the config file,when the
renderInvestigationTabexpects the value ofdata-testgiturlretrieved frominvestigation_ajaxin the form of http://github.com///commit
Apply the same substitution as in git before return
Signed-off-by: ybonatakis ybonatakis@suse.com