Prevent unnecessary linebreak in cache service logging #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4601 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 375 375
Lines 34440 34442 +2
=======================================
+ Hits 33748 33750 +2
Misses 692 692
Continue to review full report at Codecov.
|
Martchus
requested changes
Apr 9, 2022
There was a problem hiding this comment.
The log in the verification run now misses line breaks, e.g. look at this section:
[2022-04-09T18:45:07.696242+02:00] [info] Download of openSUSE-Tumbleweed-DVD-x86_64-Snapshot20220408-Media.iso.sha256 processed:
[info] [#710] Cache size of "/var/lib/openqa/cache" is 108 GiB, with limit 180 GiB [info] [#710] Downloading "openSUSE-Tumbleweed-DVD-x86_64-Snapshot20220408-Media.iso.sha256" from "[http://openqa1-opensuse/tests/2288695/asset/other/openSUSE-Tumbleweed-DVD-x86_64-Snapshot20220408-Media.iso.sha256"](http://openqa1-opensuse/tests/2288695/asset/other/openSUSE-Tumbleweed-DVD-x86_64-Snapshot20220408-Media.iso.sha256) [info] [#710] Content of "/var/lib/openqa/cache/openqa1-opensuse/openSUSE-Tumbleweed-DVD-x86_64-Snapshot20220408-Media.iso.sha256" has not changed, updating last use
[2022-04-09T18:45:07.698938+02:00] [debug] Found HDD_1, caching opensuse-Tumbleweed-x86_64-20220408-textmode@64bit.qcow2
|
Hmpf, so what's the opposite of |
|
Also I hoped that a test would fail so that I could extend something. |
okurz
force-pushed
the
feature/log_no_newline_poo92902
branch
2 times, most recently
from
7ae03d4
to
efdfedc
Compare
|
Updated after pair-programming session with Martchus, hotpatched on w7 with: |
The cache service log output looks like this: ``` [2021-05-20T06:08:43.0426 CEST] [info] Download of Tumbleweed.x86_64-1.0-virtualbox-Snapshot20210519.vagrant.virtualbox.box processed: [info] [os-autoinst#51] Cache size of "/var/lib/openqa/cache" is 17GiB, with limit 180GiB [info] [os-autoinst#51] Downloading "Tumbleweed.x86_64-1.0-virtualbox-Snapshot20210519.vagrant.virtualbox.box" from "http://openqa1-opensuse/tests/1750006/asset/other/Tumbleweed.x86_64-1.0-virtualbox-Snapshot20210519.vagrant.virtualbox.box" [info] [os-autoinst#51] Size of "/var/lib/openqa/cache/openqa1-opensuse/Tumbleweed.x86_64-1.0-virtualbox-Snapshot20210519.vagrant.virtualbox.box" is 312MiB, with ETag ""137afea0-5c2b8033306c0"" [info] [os-autoinst#51] Download of "/var/lib/openqa/cache/openqa1-opensuse/Tumbleweed.x86_64-1.0-virtualbox-Snapshot20210519.vagrant.virtualbox.box" successful, new cache size is 19GiB ``` So there is a redundant linebreak after every `[info] [os-autoinst#51]` which we can prevent. Related progress issue: https://progress.opensuse.org/issues/92902
okurz
force-pushed
the
feature/log_no_newline_poo92902
branch
from
efdfedc
to
210dbf6
Compare
|
Updated, see verified in https://openqa.opensuse.org/tests/2291609/logfile?filename=autoinst-log.txt Now the output looks like this: so no redundant linebreaks, no redundant markers, every line is properly prefixed and every block is terminated by a blank line. |
Martchus
approved these changes
Apr 11, 2022
kalikiana
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache service log output looks like this:
So there is a redundant linebreak after every
[info] [#51]which we can prevent.Verified in https://openqa.opensuse.org/tests/2291609/logfile?filename=autoinst-log.txt
Now the output looks like this:
so no redundant linebreaks, no redundant markers, every line is properly prefixed and every block is terminated by a blank line.
Related progress issue: https://progress.opensuse.org/issues/92902