Improve performance of 3 api endpoints by about 312% (for O3 data) #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
force-pushed
the
k/faster_tables
branch
from
2e0c6ba
to
4e30b65
Compare
mimi1vx
approved these changes
Sep 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #4813 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 377 377
Lines 34869 34870 +1
=======================================
+ Hits 34205 34206 +1
Misses 664 664
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Martchus
reviewed
Sep 22, 2022
kraih
force-pushed
the
k/faster_tables
branch
from
4e30b65
to
7e4f399
Compare
`/api/v1/products`, `/api/v1/machines`, and `/api/v1/test_suites` share the same backend code for fetching data. The current implementation makes thousands of select queries to fetch settings. That is very inefficient, so this patch switches to a join/collapse based prefetch approach. This is slightly more efficient than a plain prefetch, because it avoids the creation of DateTime objects. See https://metacpan.org/pod/DBIx::Class::ResultSet#collapse for more information about the collapse feature. Progress: https://progress.opensuse.org/issues/94667
kraih
force-pushed
the
k/faster_tables
branch
from
7e4f399
to
3c2a4b7
Compare
Martchus
approved these changes
Sep 22, 2022
|
So the only thing I missed in my original suggestion was the order 🤦 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/api/v1/products,/api/v1/machines, and/api/v1/test_suitesshare the same backend code for fetching data. The current implementation makes thousands of select queries to fetch settings. That is very inefficient, so this patch switches to a join/collapse based prefetch approach. This is slightly more efficient than a plain prefetch, because it avoids the creation of DateTime objects. See https://metacpan.org/pod/DBIx::Class::ResultSet#collapse for more information about the collapse feature.Progress: https://progress.opensuse.org/issues/94667