Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing wait_for_ajax call in comments test #4944

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

Martchus
Copy link
Contributor

@Martchus Martchus commented Dec 6, 2022

We must wait until the AJAX call for submitting the comment has been processed before reloading the page.

Discovered when investigating https://progress.opensuse.org/issues/121042 but won't fix that issue.

We must wait until the AJAX call for submitting the comment has been
processed before reloading the page.

Discovered when investigating https://progress.opensuse.org/issues/121042
but won't fix that issue.
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #4944 (ecbf7a9) into master (fac057e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4944   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         379      379           
  Lines       35395    35396    +1     
=======================================
+ Hits        34748    34749    +1     
  Misses        647      647           
Impacted Files Coverage Δ
t/ui/15-comments.t 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mergify mergify bot merged commit 733f44c into os-autoinst:master Dec 6, 2022
@Martchus Martchus deleted the comments-test branch December 6, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants