Split big transaction in stale job detection #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Martchus
commented
Dec 12, 2022
Martchus
commented
- Using a separate transaction per job is likely good enough and has the advantage that other components see changes faster and there's less potential for deadlocks
- Related issue: https://progress.opensuse.org/issues/121768
* Using a separate transaction per job is likely good enough and has the advantage that other components see changes faster and there's less potential for deadlocks * Related issue: https://progress.opensuse.org/issues/121768
baierjan
approved these changes
Dec 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #4955 +/- ##
==========================================
- Coverage 98.17% 98.17% -0.01%
==========================================
Files 379 379
Lines 35412 35410 -2
==========================================
- Hits 34765 34763 -2
Misses 647 647
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kalikiana
approved these changes
Dec 12, 2022
|
Good idea. We should try to keep all transaction scopes as small as possible. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.