Add openQA status badges #5022
Add openQA status badges #5022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5022 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 379 379
Lines 35570 35598 +28
=======================================
+ Hits 34929 34957 +28
Misses 641 641
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
|
There was a problem hiding this comment.
A unit test is missing. Note that functions of https://docs.mojolicious.org/Test/Mojo (like element_exists) should also work with SVG.
asdil12
force-pushed
the
badge
branch
4 times, most recently
from
3abec4e
to
04fdf82
Compare
|
This isn't merged automatically because the patch coverage is not 100 %. You're very close so I suppose it makes sense to extend the unit tests just a little bit further. |
There was a problem hiding this comment.
I suggest to carefully check the existing uses of the word "badge". For example there is http://open.qa/docs/#_review_badges from which we should distinguish. I think the route names are fine but in the implementation and whenever a text is visible to users we should use a unique string. How about "test result badge"? But also it looks like you mix states and results.
To be able to help better I would need more explanation about the use cases you want to accomplish.
Please also extend documentation to mention the use. It can be simple, basically what you put into the commit message should be documentation and the commit message should explain your decisions and motivation and design choices.
I understood your comment about documentation in the way that you wanted to have a more extensive commit message.
Is this not what you meant? |
|
@asdil12 No, he wants information like what you already had in the commit message to be added in addition to the documentation. |
Ticket: https://progress.opensuse.org/issues/124173 The badges can be used to show the current status of an openQA job eg. within a github PR. The badges can be accessed for any job via: /tests/123/badge /tests/latest/badge They support the get parameter 'show_build=1' that will prefix the status with the build number (useful for the /latest/badge).
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
Co-authored-by: Martchus <martchus@gmx.net>
Since os-autoinst/openQA#5022 enables badges on o3, we can now add that to multiple places, not only to showcase but also as a visual aid, especially on PR.
Since os-autoinst/openQA#5022 enables badges on o3, we can now add that to multiple places, not only to showcase but also as a visual aid, especially on PR.
Since os-autoinst/openQA#5022 enables badges on o3, we can now add that to multiple places, not only to showcase but also as a visual aid, especially on PR.
Ticket: https://progress.opensuse.org/issues/124173
The badges can be accessed for any job via:
They support the get parameter
show_build=1that willprefix the status with the build number (useful for the
/latest/badge).The badge will mostly use the colors as defined in the openQA theme but there are some small changes to ensure readability with the white text.
The width of the badge is automatically aligned to the length of the status text.