Fix logging reason of auth errors #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5048 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 383 383
Lines 35982 35985 +3
=======================================
+ Hits 35350 35355 +5
+ Misses 632 630 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The `$reason` variable needs to be set before printing the log message. Otherwise only the generic default will be printed.
perlpunk
approved these changes
Mar 27, 2023
os-autoinst-bot
pushed a commit
to os-autoinst-bot/openQA
that referenced
this pull request
Mar 28, 2023
commit 5ee8212 Merge: fcd0314 9792927 Author: Cris Dywan <cdywan@suse.de> AuthorDate: Mon Mar 27 19:26:17 2023 +0200 Commit: GitHub <noreply@github.com> CommitDate: Mon Mar 27 19:26:17 2023 +0200 Merge pull request os-autoinst#5048 from Martchus/auth-logging Fix logging reason of auth errors
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$reasonvariable needs to be set before printing the log message. Otherwise only the generic default will be printed.