Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrast of progress bar showing number of failures #5080

Merged
merged 1 commit into from Apr 21, 2023

Conversation

Lokeshsri11
Copy link
Contributor

@Lokeshsri11 Lokeshsri11 commented Apr 17, 2023

This commit aims to enhance the contrast of the progress bar used to display the number of failures. The previous implementation had low contrast, making it difficult to discern the actual progress. The updated design uses a more prominent color scheme, improving visibility and making it easier to understand the number of failures at a glance. This change improves the overall user experience and ensures that the progress bar is more accessible to all users.

232456699-4f5afdd7-306c-4399-856b-b8725b85bd3d

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching assets/stylesheets/**:

  • Consider providing screenshots in a PR comment to show the difference visually

This is an automatically generated QA checklist based on modified files.

@Martchus
Copy link
Contributor

Martchus commented Apr 17, 2023

The commit message is not very clear. I'd rephrase it as "Improve contrast of progress bar showing number of failures" and also add a brief version of the description you've so far only added as PR description as commit message body.

The change itself looks good to merge.

@Lokeshsri11 Lokeshsri11 changed the title Fix progress bar color for failed palette to improve visibility of text Improve contrast of progress bar showing number of failures Apr 17, 2023
@Lokeshsri11
Copy link
Contributor Author

@Martchus See the description, is it right now?

@mimi1vx mimi1vx requested a review from Martchus April 21, 2023 08:14
@Martchus
Copy link
Contributor

No it is not. I was talking about the commit message and not the pull request title. However, I can just change it when merging manually.

@Martchus Martchus merged commit cbbc51b into os-autoinst:master Apr 21, 2023
33 checks passed
@Martchus
Copy link
Contributor

Martchus commented Apr 21, 2023

I've merged it as cbbc51b. Notice that the commit itself contains the updated title/body. If you wanted to update the commit itself yourself you need to use git commit --amend (or an interactive rebase it if isn't just about the last commit) and then force-push. Using GitHub's UI isn't going to change the commit itself.

@Lokeshsri11
Copy link
Contributor Author

No it is not. I was talking about the commit message and not the pull request title. However, I can just change it when merging manually.

okay :)

os-autoinst-bot pushed a commit to os-autoinst-bot/openQA that referenced this pull request Apr 22, 2023
commit cbbc51b
Author:     LOKESH SRIVASTAVA <93934416+Lokeshsri11@users.noreply.github.com>
AuthorDate: Fri Apr 21 14:33:20 2023 +0530
Commit:     GitHub <noreply@github.com>
CommitDate: Fri Apr 21 11:03:20 2023 +0200

     Improve contrast of progress bar showing number of failures (os-autoinst#5080)

    This commit aims to enhance the contrast of the progress bar used to display the number of failures. The previous implementation had low contrast, making it difficult to discern the actual progress. The updated design uses a more prominent color scheme, improving visibility and making it easier to understand the number of failures at a glance. This change improves the overall user experience and ensures that the progress bar is more accessible to all users.
os-autoinst-bot pushed a commit to os-autoinst-bot/openQA that referenced this pull request Apr 23, 2023
commit cbbc51b
Author:     LOKESH SRIVASTAVA <93934416+Lokeshsri11@users.noreply.github.com>
AuthorDate: Fri Apr 21 14:33:20 2023 +0530
Commit:     GitHub <noreply@github.com>
CommitDate: Fri Apr 21 11:03:20 2023 +0200

     Improve contrast of progress bar showing number of failures (os-autoinst#5080)

    This commit aims to enhance the contrast of the progress bar used to display the number of failures. The previous implementation had low contrast, making it difficult to discern the actual progress. The updated design uses a more prominent color scheme, improving visibility and making it easier to understand the number of failures at a glance. This change improves the overall user experience and ensures that the progress bar is more accessible to all users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants